[PATCH] Staging: wlags49_h2: fixed C99 comments style issues in wl_profile.c

Prashant Shah pshah.mumbai at gmail.com
Mon May 10 16:52:16 UTC 2010


Hi,

>> -//     } else {
>> -//             this should not be debug time info, it is an enduser data entry error ;?
>> -//             DBG_WARNING(DbgInfo, "%s invalid; will be ignored\n", PARM_NAME_MICROWAVE_ROBUSTNESS);
>> +/*     } else {
>> +               this should not be debug time info, it is an enduser data entry error ;?
>> +               DBG_WARNING(DbgInfo, "%s invalid; will be ignored\n", PARM_NAME_MICROWAVE_ROBUSTNESS); */
> In such case you have lost the internal comments. I think it should look like
> /*
> } else {
> /* ... */

Sent a new patch. I tried the nested comments but gcc wont handle it
correctly (maybe I am wrong here). Please discard the old patch and
use this new one.

-//     } else {
-//             this should not be debug time info, it is an enduser
data entry error ;?
-//             DBG_WARNING(DbgInfo, "%s invalid; will be ignored\n",
PARM_NAME_MICROWAVE_ROBUSTNESS);
+       /* } else { */
+               /* this should not be debug time info, it is an
enduser data entry error ;? */
+               /* DBG_WARNING(DbgInfo, "%s invalid; will be
ignored\n", PARM_NAME_MICROWAVE_ROBUSTNESS); */



More information about the devel mailing list