[patch v2] batman: cleanup: change test for end of array

Jiri Slaby jirislaby at gmail.com
Mon Mar 29 07:54:15 UTC 2010


On 03/29/2010 09:12 AM, Marek Lindner wrote:
> On Sunday 28 March 2010 21:13:35 Dan Carpenter wrote:
>> @@ -43,10 +43,7 @@ static struct device_client *device_client_hash[256];
>>
>> -	for (i = 0; i < 256; i++)
>> -		device_client_hash[i] = NULL;
>> +	memset(&device_client_hash, 0, sizeof(device_client_hash));
> 
> I might be mistaken but it looks like the "&" is wrong here. Shouldn't it be:
> memset(device_client_hash, 0, sizeof(device_client_hash));

It's the same if device_client_hash is an array. The same holds for
functions.


-- 
js



More information about the devel mailing list