[PATCH] staging: winbond: wb35reg_f.h Coding style fixes.

Pekka Enberg penberg at cs.helsinki.fi
Mon Mar 22 07:16:25 UTC 2010


Lars Lindley kirjoitti:
> I fixed the checkpatch things except a couple of long lines.
> I also removed hungarian notation from the argument names
> and some "commented away" code.
> 
> Signed-off-by: Lars Lindley <lindley at coyote.org>

Did you check that all these function declarations are actually used? 
I've spotted plenty of dead code in the past.

> +/*
> + * ====================================
> + * Interface function declare
> + * ====================================
> + */
> +unsigned char Wb35Reg_initial(struct hw_data *HwData);

Lets avoid CamelCase for the arguments so "hw_data" here, for example. I 
see the same thing elsewhere in this patch as well.



More information about the devel mailing list