[PATCH 1/8] p9auth: set fsuid

Ashwin Ganti ashwin.ganti at gmail.com
Thu Mar 4 22:04:10 UTC 2010


On Fri, Feb 26, 2010 at 10:19 AM, Serge E. Hallyn <serue at us.ibm.com> wrote:
> Ashwin, Ron, Eric, (whoever else cares to take a look) I will put
> up a git tree hopefully this weekend or monday... hmm, hang on, already
> exists - you can take a look at
> http://git.kernel.org/gitweb.cgi?p=linux/kernel/git/sergeh/linux-cr.git;a=shortlog;h=refs/heads/p9auth.feb16.3
>

Greg/Serge: Sorry for the delay. I am okay with the patches in
general.  Thanks for making the reaping of old capabilities change as
well along with these.

The only comment I have is that it would be nice to have a README file
in the p9auth directory describing these changes to the semantics.
Especially since we are handling groups, file system checks etc. which
is going through the capability string, it would be easier and helpful
to understand if there is some basic documentation on each of these
changes.

Also, I don't know if you want to further get them looked by someone
more knowledgeable to comment on the implications of modifying/moving
the set*id functions over but they look alright to me.

I have requested Eric too a couple of days ago to take a look at these
patches if he finds time.

Thanks,
Ashwin



More information about the devel mailing list