[PATCH] Staging: vt6655: simplify broadcast and multicast ethernet address test

Joe Perches joe at perches.com
Wed Jun 30 06:44:11 UTC 2010


On Tue, 2010-06-29 at 23:32 -0700, Charles Clément wrote:
> A broadcast address is also a multicast address so simplify test cases where
> possible.

So the tests could be simplified to is_multicast_ether_addr.

> As suggested by Joe Perches.

Well, kind of ;)

> Signed-off-by: Charles Clément <caratorn at gmail.com>

> -    if (!is_multicast_ether_addr(pbyFrame) && !is_broadcast_ether_addr(pbyFrame)) {
> +    if (!is_broadcast_ether_addr(pbyFrame)) {

nack.

cheers, Joe




More information about the devel mailing list