[PATCH] staging/wlags49_h2: Fix build error when CONFIG_SYSFS is not set

Dan Carpenter error27 at gmail.com
Thu Jun 17 19:21:23 UTC 2010


On Thu, Jun 17, 2010 at 07:23:32PM +0200, Henk de Groot wrote:
> Javier,
>
> I assumed Greg KH already added this last version of your patch to the  
> queue for the staging tree. Anyway I think it's fine. The only problem I  
> see is a possible complained from the compiler because of an argument  
> that's defined but never used.

Gcc never complains about arguments that aren't used.  You often need to
do this so that your function matches how a function pointer is defined.

I also tested this.  To disable CONFIG_SYSFS do a "make allnoconfig"
then enable CONFIG_EMBEDDED, then you can disable CONFIG_SYSFS.  It's
deliberately a pain in the arse I suppose.

It's not a huge deal to have a #define either, but Joe Perches is right
that the current fix really is the better one.

regards,
dan carpenter




More information about the devel mailing list