[PATCH] staging:comedi: Fixed coding convention issues.
joe at perches.com
Sun Jun 13 05:07:06 UTC 2010
On Sun, 2010-06-13 at 10:14 +0800, Mark Rankilor wrote:
> 2010/6/12 Henri Häkkinen <henuxd at gmail.com>:
> > - printk
> > - (KERN_INFO "comedi: failed to increment module count, skipping\n");
> > + printk(KERN_INFO "comedi: failed to increment module "
> > + "count, skipping\n");
> Regarding your breaking up of printk statements, although some of
> those lines do go over 80 characters, it is preferable to keep the
> strings together since then those are searchable within the code.
> I figure it is quite acceptable to break the string after "comedi: ",
> so maybe that will fix the line length issue, otherwise it is
> preferable to keep the checkpatch warning in this case.
A couple of options for comedi:
1: Use #define pr_fmt(fmt) "comedi: " fmt
2: Create some comedi logging functions or macros like:
comedi_<level>(fmt, arg...) (ie: comedi_info, comedi_err, etc)
where "comedi:" is always prefixed and an
optional #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
could be used.
That'd shorten line lengths quite a bit and add
some better standardization to comedi.
More information about the devel