[PATCH] staging:comedi: Fixed coding convention issues.

Mark Rankilor reodge at gmail.com
Sun Jun 13 02:14:41 UTC 2010


2010/6/12 Henri Häkkinen <henuxd at gmail.com>:
> -                       printk
> -                           (KERN_INFO "comedi: failed to increment module count, skipping\n");
> +                       printk(KERN_INFO "comedi: failed to increment module "
> +                              "count, skipping\n");

Hi Henri,

Regarding your breaking up of printk statements, although some of
those lines do go over 80 characters, it is preferable to keep the
strings together since then those are searchable within the code.

I figure it is quite acceptable to break the string after "comedi: ",
so maybe that will fix the line length issue, otherwise it is
preferable to keep the checkpatch warning in this case.

Mark



More information about the devel mailing list