[patch v2] Staging: otus: fix strcpy() overflow

Dan Carpenter error27 at gmail.com
Mon Jun 7 21:44:57 UTC 2010


wrq->name is only 16 characters long but "IEEE 802.11-MIMO" is 16
characters + a NULL character, so it's too long.  This patch changes it
to "IEEE 802.11abgn".

Signed-off-by: Dan Carpenter <error27 at gmail.com>
---
V2:  Luis R. Rodriguez suggested that "IEEE 802.11abgn" was the correct
name to use.

diff --git a/drivers/staging/otus/ioctl.c b/drivers/staging/otus/ioctl.c
index a48c8e4..b85f1b2 100644
--- a/drivers/staging/otus/ioctl.c
+++ b/drivers/staging/otus/ioctl.c
@@ -507,7 +507,7 @@ int usbdrvwext_giwname(struct net_device *dev,
 {
 	/* struct usbdrv_private *macp = dev->ml_priv; */
 
-	strcpy(wrq->name, "IEEE 802.11-MIMO");
+	strcpy(wrq->name, "IEEE 802.11abgn");
 
 	return 0;
 }



More information about the devel mailing list