[patch] Staging: otus: fix strcpy() overflow
Luis R. Rodriguez
lrodriguez at atheros.com
Mon Jun 7 21:25:05 UTC 2010
On Mon, Jun 07, 2010 at 02:18:50PM -0700, Dan Carpenter wrote:
> wrq->name is only 16 characters long but "IEEE 802.11-MIMO" is 16
> characters + a NULL character, so it's too long. I changed the name to
> just "802.11-MIMO".
>
> Signed-off-by: Dan Carpenter <error27 at gmail.com>
>
> diff --git a/drivers/staging/otus/ioctl.c b/drivers/staging/otus/ioctl.c
> index a48c8e4..3887932 100644
> --- a/drivers/staging/otus/ioctl.c
> +++ b/drivers/staging/otus/ioctl.c
> @@ -507,7 +507,7 @@ int usbdrvwext_giwname(struct net_device *dev,
> {
> /* struct usbdrv_private *macp = dev->ml_priv; */
>
> - strcpy(wrq->name, "IEEE 802.11-MIMO");
> + strcpy(wrq->name, "802.11-MIMO");
Nack, use instead:
IEEE 802.11abgn
Luis
More information about the devel
mailing list