[PATCH] Staging: dt3155: properly export the module parameter

H Hartley Sweeten hartleys at visionengravers.com
Thu Jul 29 00:55:32 UTC 2010


On Wednesday, July 28, 2010 1:59 PM, Jiri Slaby wrote:
> On 07/28/2010 06:48 PM, H Hartley Sweeten wrote:
>> Make the module parameter dt3155_major static and add the proper
>> wrappers to export it.
>> 
>> Signed-off-by: H Hartley Sweeten <hsweeten at visionengravers.com>
>> Cc: Greg Kroah-Hartman <gregkh at suse.de>
>> Cc: Scott Smedley <ss at aao.gov.au>
>> ---
>> 
>> diff --git a/drivers/staging/dt3155/dt3155_drv.c b/drivers/staging/dt3155/dt3155_drv.c
>> index 7316996..220eaf9 100644
>> --- a/drivers/staging/dt3155/dt3155_drv.c
>> +++ b/drivers/staging/dt3155/dt3155_drv.c
>> @@ -99,7 +99,9 @@ wait_queue_head_t dt3155_read_wait_queue[MAXBOARDS];
>>  
>>  /* set to dynamicaly allocate, but it is tunable: */
>>  /* insmod DT_3155 dt3155 dt3155_major=XX */
>> -int dt3155_major = 0;
>> +static int dt3155_major;
>> +module_param(dt3155_major, int, 0);
>> +MODULE_PARM_DESC(dt3155_major, "Major device number");
>
> Is it necessary in the age of udev?
>
> I would personally get rid of that completely...

I agree but I'm not quite sure if the user space app is ready to handle that.

Scott, can you provide any input?

Regards,
Hartley


More information about the devel mailing list