[PATCH] Staging: dt3155: make local variables static

Joe Perches joe at perches.com
Fri Jul 23 18:58:48 UTC 2010


On Fri, 2010-07-23 at 11:45 -0700, H Hartley Sweeten wrote:
> The symbols dt3155_dev_open, unique_tag, and allocatorAddr are only used in
> the file dt3155_drv.c and should be static.
> diff --git a/drivers/staging/dt3155/dt3155_drv.c b/drivers/staging/dt3155/dt3155_drv.c
> index 9e7b880..49924d0 100644
> --- a/drivers/staging/dt3155/dt3155_drv.c
> +++ b/drivers/staging/dt3155/dt3155_drv.c
> @@ -118,14 +118,14 @@ static void __iomem *dt3155_lbase[MAXBOARDS] = { NULL
[]
> -u32  dt3155_dev_open[MAXBOARDS] = {0
> +static u32  dt3155_dev_open[MAXBOARDS] = {0
[]
> -u32 unique_tag = 0;;
> +static u32 unique_tag = 0;;

Statics don't need initialization and could you fix
the style issues ("{0", ";;") at the same time please?

static u32 dt3155_dev_open[MAXBOARDS];
static u32 unique_tag;





More information about the devel mailing list