[PATCH] Staging: comedi: comedidev: Fixed a macro definition code style issue

Jiri Slaby jirislaby at gmail.com
Fri Jul 23 10:36:44 UTC 2010


On 07/23/2010 11:17 AM, Michael Jensen wrote:
> On Fri, Jul 23, 2010 at 6:53 PM, Jiri Slaby <jirislaby at gmail.com> wrote:
>>
> <snip>
>> Hmm, does this compile?
>>
> I did build the comedi directory (as per Greg's "Write and submit your
> first kernel patch" video), and didn't get any errors (once I'd done
> the configuration)...
> 
> Did I miss something?

Then the macro is probably unused (or unused in your configuration).
Either way, the macro seems to be intended for use in the top-level
scope, so do { } while (0) cannot be used there.

-- 
js



More information about the devel mailing list