[PATCH 1/3] Staging: vt6655: remove boolean TRUE

Joe Perches joe at perches.com
Tue Jul 6 22:53:34 UTC 2010


On Tue, 2010-07-06 at 08:18 -0700, Greg KH wrote:
> On Tue, Jul 06, 2010 at 04:45:41PM +0200, Charles Clément wrote:
> >              case WLAN_EID_RSN_WPA:
> >                  if (pFrame->pRSNWPA == NULL) {
> > -                    if (WPAb_Is_RSN((PWLAN_IE_RSN_EXT)pItem) == TRUE)
> > +                    if (WPAb_Is_RSN((PWLAN_IE_RSN_EXT)pItem) == 1)
> That's great, but if you convert these to use the 'bool' type, why not
> then use the 'true' and 'false' enumerated types that are in the kernel
> already?
> That would make a bit more sense, right?

It'd make even more sense to drop the comparisons to == 1 or == TRUE
and just use:
	if (WPAb_Is_RSN((PWLAN_IE_RSN_EXT)pItem))





More information about the devel mailing list