[PATCH] Staging: dt3155: fix coding style issues in dt3155_drv.c

Aldo Cedillo aldobrett11 at gmail.com
Tue Jul 6 17:25:35 UTC 2010


> diff --git a/drivers/staging/dt3155/dt3155_drv.c b/drivers/staging/dt3155/dt3155_drv.c
> index 66db878..f6edd66 100644
> --- a/drivers/staging/dt3155/dt3155_drv.c
> +++ b/drivers/staging/dt3155/dt3155_drv.c
> @@ -308,33 +308,42 @@ static void dt3155_isr(int irq, void *dev_id, struct pt_regs *regs)
>  #endif
>                        if (fb->nbuffers > 2) {
>                                if (!are_empty_buffers(minor)) {
> -                                       /* The number of active + locked buffers is
> -                                        * at most 2, and since there are none empty, there
> -                                        * must be at least nbuffers-2 ready buffers.
> -                                        * This is where we 'drop frames', oldest first. */
> +                                       /* The number of active +
> +                                        * locked buffers is at most 2,
> +                                        * and since there are none empty,
> +                                        * there must be at least nbuffers-2
> +                                        * ready buffers.
> +                                        * This is where we 'drop frames',
> +                                        * oldest first. */
>                                        push_empty(pop_ready(minor),  minor);
>                                }
>

In the CodingStyle in the kernel you can read:

The preferred style for long (multi-line) comments is:

        /*
         * This is the preferred style for multi-line
         * comments in the Linux kernel source code.
         * Please use it consistently.
         *
         * Description:  A column of asterisks on the left side,
         * with beginning and ending almost-blank lines.
         */

Again I ask about the coding style because I have seen in many parts of the
kernel I've seen discrepancies with what is said in the CodingStyle file. So
I want to get it clear maybe I can help to clean those things.

Thanks,
Aldo Brett



More information about the devel mailing list