question about drivers/staging/quatech_usb2/quatech_usb2.c

Jiri Slaby jirislaby at gmail.com
Thu Feb 25 14:48:47 UTC 2010


On 02/24/2010 03:06 AM, Greg KH wrote:
> On Mon, Feb 22, 2010 at 08:14:36AM +0100, Julia Lawall wrote:
>> The code below seems suspicious.  Which definition of nSWflowout is
>> the right one?
> 
> I really have no idea, the last one, as that seems to be the one that
> the code is actually doing?  :)

I don't know the code and HW either, but I would say the second should
rather be '|=':
	nSWflowout = start_char << 8;
 	nSWflowout |= (unsigned short)stop_char;
which makes sense.

regards,
-- 
js



More information about the devel mailing list