[PATCH 1/8] p9auth: set fsuid

Serge E. Hallyn serue at us.ibm.com
Fri Feb 26 04:05:53 UTC 2010


Quoting Greg KH (greg at kroah.com):
> On Tue, Feb 16, 2010 at 04:44:54PM -0600, Serge Hallyn wrote:
> > From: Serge E. Hallyn <serue at us.ibm.com>
> > 
> > fsuid should always trail euid changes.  So p9auth should
> > set fsuid as well when it sets ruid and euid.  Whether the
> > suid should also be set is an open question - keeping the
> > old uid in suid may be useful, or may just serve to trick
> > lazy userspace.
> > 
> > Note that so long as we do not also set suid, the setuid_fixup()
> > code will not (when we later switch to setresuid()) fully
> > fill/clear capability sets.  So while I had previously thought
> > that keeping suid unchanged would be useful, I think it is
> > better to change all uids.

Hi Greg,

> What is your goal for the p9auth code?  Currently it is deleted in
> linux-next due to a lack of development.  I see you have some cleanup
> patches, but I can't apply them unless you get the non-staging patches
> accepted.

Sorry, what do you mean by 'the non-staging patches'?  Do you mean
the staging patches that were dropped, the cleanup patches (that
wouldn't make sense), or another set of patches?

> If I bring the driver back from deletion, will you work to fix it up and
> get it merged into mainline?

Yes.

> What's the word on the non-staging patches in this series being
> accepted?

Again, I'm not quite sure which you mean by the non-staging patches,
or what you mean by accepted - do you mean general community acceptance
of the base p9auth patches, or acceptance of my p9uath patches by
Ashwin etc?

thanks,
-serge



More information about the devel mailing list