question about drivers/staging/quatech_usb2/quatech_usb2.c

[Julia Lawall]

The code below seems suspicious.  Which definition of nSWflowout is
the right one?

This is not intended as a proper patch.  I can send a proper patch when I
know what to do.

julia



diff -u -p a/drivers/staging/quatech_usb2/quatech_usb2.c b/drivers/staging/quatech_usb2/quatech_usb2.c
--- a/drivers/staging/quatech_usb2/quatech_usb2.c
+++ b/drivers/staging/quatech_usb2/quatech_usb2.c
@@ -1915,7 +1915,6 @@ static int qt2_boxsetsw_flowctl(struct u
 {
 	__u16 nSWflowout;
 
-	nSWflowout = start_char << 8;
 	nSWflowout = (unsigned short)stop_char;
 	return usb_control_msg(serial->dev, usb_sndctrlpipe(serial->dev, 0),
 			QT2_SW_FLOW_CONTROL_MASK, 0x40, nSWflowout, UartNumber,