[patch] staging: vt6655: rewrite CARDvUpdateBasicTopRate()

Dan Carpenter error27 at gmail.com
Sat Feb 13 10:06:16 UTC 2010


On Sat, Feb 13, 2010 at 10:44:53AM +0100, Jiri Slaby wrote:
> On 02/13/2010 10:36 AM, Jiri Slaby wrote:
> > You cannot use ffs and fls here.
> 
> Actually you can (fls), if you add proper masks there like
> fls(pDevice->wBasicRate & ((1 << RATE_24M) - 1) & ~((1 << RATE_6M) -
> 1)), but with some macro-ification inside. Dunno if it gets better though.
> 

Ok.  I didn't understand how ffs() and fls() worked before.  Sorry about that.

Let's just apply my original patch because that is an obvious one.

If I could test my changes, I would feel more comfortable rewriting stuff
but I don't have the hardware.

regards,
dan carpenter

> -- 
> js





More information about the devel mailing list