[PATCH 1/1] Staging: hv: Add proper versioning to HV drivers-Corrected.
Luis R. Rodriguez
mcgrof at gmail.com
Fri Feb 12 19:39:44 UTC 2010
On Fri, Feb 12, 2010 at 10:47 AM, Greg KH <gregkh at suse.de> wrote:
> On Fri, Feb 12, 2010 at 05:55:34PM +0000, Hank Janssen wrote:
>> > >
>> > > drivers/staging/hv/VersionInfo.h | 22 +++++++++++++++++++---
>> > You forgot a "---" between the signed-off-by and the diffstat. If you
>> > use either git or quilt, it will get this correct automagically. That
>> > infers you used something else, which is quite scary. What are you
>> > using instead to create patches?
>> > Don't worry, I can edit this by hand when I apply it, and will do so in
>> > a few days when I get to my "to-apply" queue, but in the future, please
>> > don't do this.
>> > thanks,
>> > greg k-h
>> This must have been the result of a cut/paste error on my side.
>> I use the following command for my diff 'git diff -M -u --stat'
> What's wrong with 'git format-patch'?
> You are creating a "raw" diff, which is fine, but you then need to
> include the rest of the comments. If you commit the patch to a branch,
> with the comments in them, then you can just automatically create the
> patches in correct format.
In case this helps:
Toward s the end there is a git format-patch blurb and explains how to
set up your e-mail client with ssmpt.
More information about the devel