[PATCH 1/1] Staging: hv: Add proper versioning to HV drivers-Corrected.

Hank Janssen hjanssen at microsoft.com
Fri Feb 12 17:55:34 UTC 2010


> >
> >  drivers/staging/hv/VersionInfo.h |   22 +++++++++++++++++++---
> 
> You forgot a "---" between the signed-off-by and the diffstat.  If you
> use either git or quilt, it will get this correct automagically.  That
> infers you used something else, which is quite scary.  What are you
> using instead to create patches?
> 
> Don't worry, I can edit this by hand when I apply it, and will do so in
> a few days when I get to my "to-apply" queue, but in the future, please
> don't do this.
> 
> thanks,
> 
> greg k-h

This must have been the result of a cut/paste error on my side.

I use the following command for my diff   'git diff -M -u --stat'

Btw, it was my understanding that the -M flag allows tracking of renamed 
files as well as part of the diff output. (git mv) But my diff command 
does not report on those.  Am I doing something wrong?

Thanks,

Hank.




More information about the devel mailing list