[PATCH] staging: speakup: more fixes for init-failure handling.

Christopher Brannon chris at the-brannons.com
Sun Dec 19 11:33:42 UTC 2010


Dan Carpenter <error27 at gmail.com> writes:

> I'm not a big fan of the global variables approach to unwinding...  It
> makes reading the code much harder.

What's the best way to do this, while limiting duplication?
Basically, we have to solve the same problem in two places: unsuccessful
initialization and successful termination.

>> +/* These first few initializations cannot fail. */
>
> The indenting is wrong here.

Oops, sorry about this!  While I'm no fan of excuses, mine is that I use
synthetic speech.  Whitespace errors tend to creep in, at times.

>> +	pr_warn("synth name on entry is: %s\n", synth_name);
>
> This should be a pr_info() instead of a pr_warn().

Fixed in my latest revision.  We've had a pr_warn there for years,
and I have no idea why.

Thanks for the review!  If it's basically ok, I'll resend.

Regards,
-- Chris



More information about the devel mailing list