[PATCH] staging: speakup: more fixes for init-failure handling.
error27 at gmail.com
Sat Dec 18 09:04:29 UTC 2010
I'm not a big fan of the global variables approach to unwinding... It
makes reading the code much harder. But I didn't find any run-time bugs
so I guess this is ok. It fixes the NULL deref I mentioned before.
> +/* These first few initializations cannot fail. */
The indenting is wrong here.
> + pr_warn("synth name on entry is: %s\n", synth_name);
This should be a pr_info() instead of a pr_warn().
More information about the devel