[PATCH 2/3]: An implementation of HyperV KVP functionality

Evgeniy Polyakov zbr at ioremap.net
Tue Dec 7 22:29:33 UTC 2010


On Tue, Dec 07, 2010 at 03:25:56PM -0700, Ky Srinivasan (ksrinivasan at novell.com) wrote:
> +static void shutdown_onchannelcallback(void *context)
> +{
> +	struct vmbus_channel *channel = context;
> +	u8 *buf;
> +	u32 buflen, recvlen;
> +	u64 requestid;
> +	u8  execute_shutdown = false;
> +
> +	struct shutdown_msg_data *shutdown_msg;
> +
> +	struct icmsg_hdr *icmsghdrp;
> +	struct icmsg_negotiate *negop = NULL;
> +
> +	buflen = PAGE_SIZE;
> +	buf = kmalloc(buflen, GFP_ATOMIC);
> +
> +	vmbus_recvpacket(channel, buf, buflen, &recvlen, &requestid);

This did not change since previous review and this is wrong.
It is the right way to crash kernel.

I did not read further since this is a show-stopper imo.

-- 
	Evgeniy Polyakov



More information about the devel mailing list