[PATCH 340/524] Staging: panel: fix memory leak

Greg Kroah-Hartman gregkh at suse.de
Thu Aug 5 22:22:03 UTC 2010


From: Kulikov Vasiliy <segooon at gmail.com>

panel_bind_key() must free allocated memory.

Signed-off-by: Kulikov Vasiliy <segooon at gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh at suse.de>
---
 drivers/staging/panel/panel.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/drivers/staging/panel/panel.c b/drivers/staging/panel/panel.c
index 3e07e41..aeca01c 100644
--- a/drivers/staging/panel/panel.c
+++ b/drivers/staging/panel/panel.c
@@ -1995,8 +1995,10 @@ static struct logical_input *panel_bind_key(char *name, char *press,
 		return NULL;
 	}
 	if (!input_name2mask(name, &key->mask, &key->value, &scan_mask_i,
-			     &scan_mask_o))
+			     &scan_mask_o)) {
+		kfree(key);
 		return NULL;
+	}
 
 	key->type = INPUT_TYPE_KBD;
 	key->state = INPUT_ST_LOW;
-- 
1.7.1




More information about the devel mailing list