[PATCH 09/13] drivers/staging/rtl8192su: Hoist assign from if

Greg KH greg at kroah.com
Wed Apr 28 18:27:10 UTC 2010


On Wed, Mar 24, 2010 at 10:17:03PM -0700, Joe Perches wrote:
> --- a/drivers/staging/rtl8192su/ieee80211/ieee80211_softmac.c
> +++ b/drivers/staging/rtl8192su/ieee80211/ieee80211_softmac.c
> @@ -1690,7 +1690,8 @@ ieee80211_rx_auth_rq(struct ieee80211_device *ieee, struct sk_buff *skb)
>  	//IEEE80211DMESG("Rx probe");
>  	ieee->softmac_stats.rx_auth_rq++;
>  
> -	if ((status = auth_rq_parse(skb, dest))!= -1){
> +	status = auth_rq_parse(skb, dest);
> +	if (status!= -1) {

And again.  Did you do this with some tool and not by hand?

Did you not run your patch through checkpatch after creating it and
before sending it to me?

thanks,

greg k-h



More information about the devel mailing list