[PATCH 00/49] staging: Convert printk(KERN_<LEVEL> to pr_<level>

Joe Perches joe at perches.com
Thu Oct 15 02:51:49 UTC 2009


On Wed, 2009-10-14 at 19:29 -0700, Luis R. Rodriguez wrote:
> FWIW, coccinelle spatch should work better but I have found issues
> with spatch on headers, it just won't touch them, for instance. But
> in this case wouldn't it be safer to use it first for all C files
> and then leave a script to finish he job later?

Knock yourself out.  I don't know about better, but
coccinelle would certainly work different.

You'll still need to integrated the split format strings,
which coccinelle doesn't do, reformat/align the
pr_<foo>/dev_<foo> arguments, indent the modified source,
(I used a diff/emacs script), etc.

You might also extract the embedded function names
from the constant format strings, and use %s...__func__.

cheers, Joe




More information about the devel mailing list