[PATCH] Staging: rt28x0: remove no longer needed common/cmm_data_2860.c

Darren Salt linux at youmustbejoking.demon.co.uk
Mon Nov 9 22:59:42 UTC 2009

I demand that Bartlomiej Zolnierkiewicz may or may not have written...

> On Monday 09 November 2009 18:54:38 Darren Salt wrote:
>> Your removal of cmm_data_2860.c also removes a bug fix (commit
>> 0af49167b1e5ba154e90d2c454bf4624ee47df80; for background, see
>> http://bugzilla.kernel.org/show_bug.cgi?id=13390).

> commit 0af49167b1e5ba154e90d2c454bf4624ee47df80
> Author: Darren Salt <linux at youmustbejoking.demon.co.uk>
> Date:   Wed Oct 14 02:19:22 2009 +0100
>     Staging: rt2860sta: prevent a panic when disabling when associated

> while:

> ommit 5d315c4baa7be30e0fb8c924a64406492b2263b8
> Author: Bartlomiej Zolnierkiewicz <bzolnier at gmail.com>
> Date:   Tue Sep 22 20:44:07 2009 +0200
>     Staging: rt28x0: updates from vendor's V2.1.0.0 drivers

> dropped cmm_data_2860.o from the build..

Ouch. ;-)

>> Is this fix present (or, better, not needed) in the code which obsoletes
>> this file? (I can test if needed; just point me in the right direction
>> wrt patches or repositories.)

> It seems it is still needed so could you port it over to cmm_data_pci.c
> (just use staging or linux-next as a base)?

I've tested with the Ralink drivers from -next copied into my 2.6.32-rc6 tree
(which has one bad patch from -rc5 reverted, else the bug would be masked),
and all appears to be working well.

So, unless you think that extra belt and braces would be of use here, I'm not
going to bother porting it.

| Darren Salt            | linux at youmustbejoking | nr. Ashington, | Doon
| using Debian GNU/Linux | or ds    ,demon,co,uk    | Northumberland | Army
| + http://www.youmustbejoking.demon.co.uk/

Pssst... the root password is 'kumquat'.

More information about the devel mailing list