[PATCH 155/342] Staging: wlan-ng: Lindent cleanups

Mithlesh Thukral mithlesh at linsyssoft.com
Wed Jun 24 05:57:08 UTC 2009


On Wednesday 24 June 2009 04:12:37 J.R. Mauro wrote:
> On Tue, Jun 23, 2009 at 7:41 AM, Stefan
>
> Richter<stefanr at s5r6.in-berlin.de> wrote:
> > Bernd Petrovitsch wrote:
> >> On Mon, 2009-06-22 at 13:20 +0530, Mithlesh Thukral wrote:
> >> [...]
> >>
> >>> Sure I realized this too. So for my future works, let me first do
> >>> checkpatch.pl and such structure and type def changes first and then
> >>> finally do Lindent.
> >>>
> > >From drivers/staging/wlan-ng/README:
> >
> >        - checkpatch.pl cleanups
> >        - sparse warnings
> >        - move to use the in-kernel wireless stack
> >
> > Why agonize over the trivial stuff?
>
> I mostly agree, but the people capable of doing the third thing have
> mostly expressed that they will not look at the code until they see
> the first two things done. So if our choice is that either one group
> makes the code look nice knowing their work will be tossed so that
> people will do the hard work, or the people who can do the hard work
> don't look at the code at all, we might as well have people do the
> cleanups.
>
More over cleanups are one of the simplest thing that you can do when you have 
put on a build which takes an hour to complete or you waiting for your flight 
after the security check.

> > The last step is important.  The
> > former two steps may prepare for that, but the last step will most
> > certainly involve further code changes/ code replacements.
> >
> > You could either check what these changes will roughly be, then proceed
> > with the other two steps.  Or you could blindly perform the first two
> > steps without planning for the last, and then discard a respective
> > amount of your work when you finally start the last item.  Or you could
> > leave your work unfinished and let somebody else do the last step which
> > is the really relevant one.
If you want to wait for someone else to do work and then follow it, I guess it 
might take ages.
Instead of reducing everything to "Chicken n Egg" problem why not start doing 
what ever you can.

Cheers,
Mithlesh Thukral
> >
> >> The better - admittedly pretty radical and pretty disturbing - change is
> >> IMHO to make checkpatch.pl whine on "useless use of typedef".
> >
> > Checkpatch cannot think for you.  /You/ are the one to find out what's
> > "useless" and what not.   Sometimes it's obvious, sometimes not.
> > --
> > Stefan Richter
> > -=====-==--= -==- =-===
> > http://arcgraph.de/sr/
> > _______________________________________________
> > devel mailing list
> > devel at linuxdriverproject.org
> > http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
>
> _______________________________________________
> devel mailing list
> devel at linuxdriverproject.org
> http://driverdev.linuxdriverproject.org/mailman/listinfo/devel




More information about the devel mailing list