[PATCH 155/342] Staging: wlan-ng: Lindent cleanups

[Mithlesh Thukral]

On Sunday 21 June 2009 04:29:29 J.R. Mauro wrote:
> On Sat, Jun 20, 2009 at 5:39 PM, Alexey Zaytsev<alexey.zaytsev at gmail.com> 
wrote:
> > On Fri, Jun 19, 2009 at 22:06, Greg Kroah-Hartman<gregkh at suse.de> wrote:
> >> From: Mithlesh Thukral
> >> Lindent script cleanups in wlan-ng driver in the staging tree.
> >>
> >> This is a item in the TODO list.
> >>
> >> Signed-off-by: Mithlesh Thukral
> >> Signed-off-by: Greg Kroah-Hartman
> >> ---
> >> drivers/staging/wlan-ng/hfa384x.h | 376 +++++++--------
> >> drivers/staging/wlan-ng/hfa384x_usb.c | 322 ++++++-------
> >> drivers/staging/wlan-ng/p80211conv.c | 21 +-
> >> drivers/staging/wlan-ng/p80211conv.h | 4 +-
> >
> > [...]
> >
> > For the most part, the patch actually makes the code look worse, like
> >
> > -void hfa384x_create(hfa384x_t *hw, struct usb_device *usb);
> > -void hfa384x_destroy(hfa384x_t *hw);
> > +void hfa384x_create(hfa384x_t * hw, struct usb_device *usb);
> > +void hfa384x_destroy(hfa384x_t * hw);
> >
> > Please revert. :(
>
> Lindent is stupid like this. I think I had some changes for it to fix
> it but I can't remember. I will look.
>
Sure I realized this too. So for my future works, let me first do 
checkpatch.pl and such structure and type def changes first and then finally 
do Lindent.
Dont know if I would find enough time to understand and fix Lindent and test 
it extensively.

Regards,
Mithlesh Thukral
> > _______________________________________________
> > devel mailing list
> > devel at linuxdriverproject.org
> > http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
>
> _______________________________________________
> devel mailing list
> devel at linuxdriverproject.org
> http://driverdev.linuxdriverproject.org/mailman/listinfo/devel