[PATCH 332/342] Staging: pata_rdc: remove broken flag

Greg Kroah-Hartman gregkh at suse.de
Fri Jun 19 18:09:16 UTC 2009


The "in_module_init" flag was wrong, so just remove it, it's not needed.


Cc: Kevin Huang  <Kevin.Huang at rdc.com.tw>
Cc: Tomy Wang <Tomy.Wang at rdc.com.tw>
Signed-off-by: Greg Kroah-Hartman <gregkh at suse.de>
---
 drivers/staging/pata_rdc/pata_rdc.c |   11 -----------
 1 files changed, 0 insertions(+), 11 deletions(-)

diff --git a/drivers/staging/pata_rdc/pata_rdc.c b/drivers/staging/pata_rdc/pata_rdc.c
index 257e622..9405128 100644
--- a/drivers/staging/pata_rdc/pata_rdc.c
+++ b/drivers/staging/pata_rdc/pata_rdc.c
@@ -38,10 +38,6 @@ static const struct pci_device_id rdc_pata_id_table[] = {
 };
 MODULE_DEVICE_TABLE(pci, rdc_pata_id_table);
 
-static unsigned int in_module_init = 1; /* hotplugging check??? */
-
-/* ata device data */
-
 /* see ATA Host Adapters Standards. */
 static struct pci_bits ATA_Decode_Enable_Bits[] = {
 	{ 0x41U, 1U, 0x80UL, 0x80UL },	/* port (Channel) 0 */
@@ -982,11 +978,6 @@ static int __devinit rdc_init_one(struct pci_dev *pdev,
 
 	dbgprintf("rdc_init_one\n");
 
-	/* no hotplugging support (FIXME) */ /* why??? */
-	if (!in_module_init) {
-		dbgprintf("rdc_init_one in_module_init == 0 failed \n");
-		return -ENODEV;
-	}
 	port_info[0] = rdc_pata_port_info[ent->driver_data];
 	port_info[1] = rdc_pata_port_info[ent->driver_data];
 
@@ -1026,8 +1017,6 @@ static int __init pata_rdc_init(void)
 		return rc;
 	}
 
-	in_module_init = 0;
-
 	return 0;
 }
 
-- 
1.6.3.2




More information about the devel mailing list