[PATCH 315/342] Staging: heci: do not print error when heci_bh_handler is already on workqueue
Greg Kroah-Hartman
gregkh at suse.de
Fri Jun 19 18:08:59 UTC 2009
From: Dongxiao Xu <dongxiao.xu at intel.com>
schedule_work returns 0, if the work is already on the work_queue, else
returns non-zero. Do not print error message if heci_bh_handlerwork was
already on queue.
Signed-off-by: Nikanth Karthikesan <knikanth at suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh at suse.de>
---
drivers/staging/heci/interrupt.c | 12 ++++--------
1 files changed, 4 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/heci/interrupt.c b/drivers/staging/heci/interrupt.c
index 3a510ed..2a3a01a 100644
--- a/drivers/staging/heci/interrupt.c
+++ b/drivers/staging/heci/interrupt.c
@@ -103,10 +103,8 @@ irqreturn_t heci_isr_interrupt(int irq, void *dev_id)
PREPARE_WORK(&dev->work, heci_bh_handler);
DBG("schedule work the heci_bh_handler.\n");
err = schedule_work(&dev->work);
- if (!err) {
- printk(KERN_ERR "heci: schedule the heci_bh_handler"
- " failed error=%x\n", err);
- }
+ if (!err)
+ DBG("heci_bh_handler was already on the workqueue.\n");
return IRQ_HANDLED;
}
@@ -260,10 +258,8 @@ end:
PREPARE_WORK(&dev->work, heci_bh_handler);
DBG("schedule work the heci_bh_handler.\n");
rets = schedule_work(&dev->work);
- if (!rets) {
- printk(KERN_ERR "heci: schedule the heci_bh_handler"
- " failed error=%x\n", rets);
- }
+ if (!rets)
+ DBG("heci_bh_handler was already queued.\n");
} else {
heci_csr_enable_interrupts(dev);
}
--
1.6.3.2
More information about the devel
mailing list