[PATCH 285/342] Staging: epl: do not use CLONE_SIGHAND with allow_signal()
Greg Kroah-Hartman
gregkh at suse.de
Fri Jun 19 18:08:29 UTC 2009
From: Oleg Nesterov <oleg at redhat.com>
Not sure this patch is really needed since kernel_thread() is deprecated
(and checkpatch.pl complains).
But we should not use kernel_thread(CLONE_SIGHAND) if we are going to play
with signals.
Signed-off-by: Oleg Nesterov <oleg at redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh at suse.de>
---
drivers/staging/epl/EplSdoUdpu.c | 3 ++-
drivers/staging/epl/ShbIpc-LinuxKernel.c | 8 ++++----
2 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/epl/EplSdoUdpu.c b/drivers/staging/epl/EplSdoUdpu.c
index b409c9b..c8e950f 100644
--- a/drivers/staging/epl/EplSdoUdpu.c
+++ b/drivers/staging/epl/EplSdoUdpu.c
@@ -334,7 +334,8 @@ tEplKernel EplSdoUdpuConfig(unsigned long ulIpAddr_p, unsigned int uiPort_p)
}
// create Listen-Thread
SdoUdpInstance_g.m_ThreadHandle =
- kernel_thread(EplSdoUdpThread, &SdoUdpInstance_g, CLONE_KERNEL);
+ kernel_thread(EplSdoUdpThread, &SdoUdpInstance_g,
+ CLONE_FS | CLONE_FILES);
if (SdoUdpInstance_g.m_ThreadHandle == 0) {
Ret = kEplSdoUdpThreadError;
goto Exit;
diff --git a/drivers/staging/epl/ShbIpc-LinuxKernel.c b/drivers/staging/epl/ShbIpc-LinuxKernel.c
index 497938b..12d1ecc 100644
--- a/drivers/staging/epl/ShbIpc-LinuxKernel.c
+++ b/drivers/staging/epl/ShbIpc-LinuxKernel.c
@@ -532,8 +532,8 @@ tShbError ShbIpcStartSignalingNewData(tShbInstance pShbInstance_p,
//create thread for signalling new data
pShbMemInst->m_tThreadNewDataId =
- kernel_thread(ShbIpcThreadSignalNewData, pShbInstance_p,
- CLONE_KERNEL);
+ kernel_thread(ShbIpcThreadSignalNewData, pShbInstance_p,
+ CLONE_FS | CLONE_FILES);
Exit:
return ShbError;
@@ -636,8 +636,8 @@ tShbError ShbIpcStartSignalingJobReady(tShbInstance pShbInstance_p,
pShbMemHeader->m_fJobReady = FALSE;
//create thread for signalling new data
pShbMemInst->m_tThreadJobReadyId =
- kernel_thread(ShbIpcThreadSignalJobReady, pShbInstance_p,
- CLONE_KERNEL);
+ kernel_thread(ShbIpcThreadSignalJobReady, pShbInstance_p,
+ CLONE_FS | CLONE_FILES);
Exit:
return ShbError;
}
--
1.6.3.2
More information about the devel
mailing list