[PATCH 00/13] staging/hv: style cleanups

Greg KH greg at kroah.com
Thu Jul 30 15:29:01 UTC 2009


On Wed, Jul 29, 2009 at 05:40:53PM -0700, Joe Perches wrote:
> Lindent and some typedef removals
> 
> Joe Perches (13):
>   staging/hv: Lindent pass

I'm all for cleaning up this code, but this patch is a mess.

Unfortunatly, about 20 patches went into the tree yesterday for this
driver and it doesn't apply at all.  But even if it did, the output of
Lindent really isn't that good.  Yes, it's better than the original, but
there are still numerous coding style issues left over.

I was just going to clean up _all_ of the style issues as the last set
of patches before sending them to Linus for the .32 merge.  That way
everyone else's patches (and there are a number of developers helping
out on this code right now) don't conflict as badly, and the code can
get up to the proper coding style all at once.

>   staging/hv/include: Lindent pass
>   staging/hv: Use struct driver_object

Please provide a much better changelog comment for these patches next
time.  You aren't "using" a structure, rather you are converting a
typedef into a structure.

>   staging/hv: use struct vmbus_driver_object
>   staging/hv: use struct vmbus_channel
>   staging/hv: use struct port_info
>   staging/hv: use struct device_info
>   staging/hv: use struct vmbus_channel_interface
>   staging/hv: use struct page_buffer

And structure names like this might wish to be rethought, that's a
pretty generic name for a driver to declare :)

Care to respin the typedef patches against the latest linux-next tree of
today?  I'll gladly take them.

thanks,

greg k-h



More information about the devel mailing list