[patch 47/54] Staging: hv: make gVmbusConnection.ChannelLock a real spinlock
gregkh at suse.de
Tue Jul 21 02:11:26 UTC 2009
On Tue, Jul 21, 2009 at 01:39:19AM +0200, Arnd Bergmann wrote:
> On Friday 17 July 2009, Greg Kroah-Hartman wrote:
> > I don't think we really want to be doing a irqsave for this code, but I
> > left it alone to preserve the original codepath. It should be reviewed
> > later.
> This patch does not preserve the original code path if any of the
> callers has a different irq state from the others. When flags is
> shared, releasing the lock actually sets the irq state to whatever
> another thread was using when failing to acquire the lock while
> it was held.
> The patch of course looks good, but the comment is misleading.
Good point, sorry for the misleading comment.
I'll let Hank work out the details as to if the irqsave mode is needed
or not :)
More information about the devel