[PATCH 5/5] staging/otus: Move a dereference below a NULL test

Jiri Slaby jirislaby at gmail.com
Sat Jul 11 11:06:45 UTC 2009


On 07/11/2009 12:17 PM, Jaswinder Singh Rajput wrote:
> On Sat, 2009-07-11 at 10:17 +0200, Jiri Slaby wrote:
>> On 07/11/2009 09:51 AM, Julia Lawall wrote:
>>> --- a/drivers/staging/otus/wwrap.c
>>> +++ b/drivers/staging/otus/wwrap.c
>>> @@ -1016,12 +1016,13 @@ void kevent(struct work_struct *work)
>>>  {
>>>      struct usbdrv_private *macp =
>>>                 container_of(work, struct usbdrv_private, kevent);
>>> -    zdev_t *dev = macp->device;
>>> +    zdev_t *dev;
>>>  
>>>      if (macp == NULL)
>>>      {
>>>          return;
>>>      }
>>
>> The test is rather useless here.
>>
> 
> Why useless, it should be non-null before setting to dev.

Even if work was NULL, macp won't be NULL.

> But issue is why function name like kevent() is global and who is using
> it.

Since it's not declared, I guess nobody but keventd. It should be static.



More information about the devel mailing list