[PATCH 5/5] staging/otus: Move a dereference below a NULL test

Jaswinder Singh Rajput jaswinder at kernel.org
Sat Jul 11 10:32:03 UTC 2009


On Sat, 2009-07-11 at 15:47 +0530, Jaswinder Singh Rajput wrote:
> On Sat, 2009-07-11 at 10:17 +0200, Jiri Slaby wrote:
> > On 07/11/2009 09:51 AM, Julia Lawall wrote:
> > > diff -u -p a/drivers/staging/otus/wwrap.c b/drivers/staging/otus/wwrap.c
> > > --- a/drivers/staging/otus/wwrap.c
> > > +++ b/drivers/staging/otus/wwrap.c
> > > @@ -1016,12 +1016,13 @@ void kevent(struct work_struct *work)
> > >  {
> > >      struct usbdrv_private *macp =
> > >                 container_of(work, struct usbdrv_private, kevent);
> > > -    zdev_t *dev = macp->device;
> > > +    zdev_t *dev;
> > >  
> > >      if (macp == NULL)
> > >      {
> > >          return;
> > >      }
> > 
> > The test is rather useless here.
> > 
> 
> Why useless, it should be non-null before setting to dev.
> 
> But issue is why function name like kevent() is global and who is using
> it.
> 
> > > +    dev = macp->device;
> > 
> > 
> 

And more funny thing is that all functions are global in this file.

Greg, can you please check the scope of these function, why all are
global.

Thanks,
--
JSR




More information about the devel mailing list