[PATCH 5/5] staging/otus: Move a dereference below a NULL test

Jiri Slaby jirislaby at gmail.com
Sat Jul 11 08:17:24 UTC 2009


On 07/11/2009 09:51 AM, Julia Lawall wrote:
> diff -u -p a/drivers/staging/otus/wwrap.c b/drivers/staging/otus/wwrap.c
> --- a/drivers/staging/otus/wwrap.c
> +++ b/drivers/staging/otus/wwrap.c
> @@ -1016,12 +1016,13 @@ void kevent(struct work_struct *work)
>  {
>      struct usbdrv_private *macp =
>                 container_of(work, struct usbdrv_private, kevent);
> -    zdev_t *dev = macp->device;
> +    zdev_t *dev;
>  
>      if (macp == NULL)
>      {
>          return;
>      }

The test is rather useless here.

> +    dev = macp->device;





More information about the devel mailing list