[PATCH] rspiusb: Check usb_buffer_map_sg() retval

Roel Kluin roel.kluin at gmail.com
Mon Aug 24 10:31:16 UTC 2009


Op 23-08-09 22:16, Jiri Slaby schreef:
> On 08/22/2009 07:32 PM, Roel Kluin wrote:
>>> you should vfree first...
>>
>> Of course. Thanks Jiri, updated patch below,
>>
>> Roel
> 
> Forgot to add signed-off-by?
> 
> Reviewed-by: Jiri Slaby <jirislaby at gmail.com>

No, it was in the top of the email - you snipped it. This is how it should be
done, I think, according to Documentation/SubmittingPatches, See section 15:
this conversation is part of `additional comments not suitable for the
changelog', and should therefore be placed between the `---' and the diff
output.

And thanks for your review,

Roel



More information about the devel mailing list