[PATCH v2] Staging: vme: Add syncronize interrupts before removing callback
Martyn Welch
martyn.welch at gefanuc.com
Tue Aug 11 12:50:49 UTC 2009
As identified by Jiri, there is no syncronisation before callback is removed.
Signed-off-by: Martyn Welch <martyn.welch at gefanuc.com>
---
It generally pays to compile the correct tree when compile testing a patch...
v2: pdev should be a pointer.
drivers/staging/vme/bridges/vme_tsi148.c | 5 +++++
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/drivers/staging/vme/bridges/vme_tsi148.c b/drivers/staging/vme/bridges/vme_tsi148.c
index cdc2919..a4929ad 100644
--- a/drivers/staging/vme/bridges/vme_tsi148.c
+++ b/drivers/staging/vme/bridges/vme_tsi148.c
@@ -480,6 +480,7 @@ int tsi148_request_irq(int level, int statid,
void tsi148_free_irq(int level, int statid)
{
u32 tmp;
+ struct pci_dev *pdev;
/* Get semaphore */
down(&(vme_irq));
@@ -495,6 +496,10 @@ void tsi148_free_irq(int level, int statid)
tmp = ioread32be(tsi148_bridge->base + TSI148_LCSR_INTEO);
tmp &= ~TSI148_LCSR_INTEO_IRQEO[level - 1];
iowrite32be(tmp, tsi148_bridge->base + TSI148_LCSR_INTEO);
+
+ pdev = container_of(tsi148_bridge->parent, struct pci_dev, dev);
+
+ synchronize_irq(pdev->irq);
}
tsi148_bridge->irq[level - 1].callback[statid].func = NULL;
More information about the devel
mailing list