[patch 02/10] ieee1394: add hpsb_node_read() and hpsb_node_lock()

Stefan Richter stefanr at s5r6.in-berlin.de
Mon Sep 29 17:17:06 UTC 2008

Date: Wed, 27 Aug 2008 13:40:02 +0200
From: Stefan Richter <stefanr at s5r6.in-berlin.de>

These will be used by the firedtv driver.  Like hpsb_node_write() they
are much better APIs for high-level drivers than hpsb_write() and its
siblings --- easier to use correctly and also terser.

Unlike hspb_node_write(), the two new functions will only be used by
one call site.  Hence make them static inline instead of exported

Signed-off-by: Stefan Richter <stefanr at s5r6.in-berlin.de>
 drivers/ieee1394/nodemgr.h |   18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

Index: linux/drivers/ieee1394/nodemgr.h
--- linux.orig/drivers/ieee1394/nodemgr.h
+++ linux/drivers/ieee1394/nodemgr.h
@@ -21,9 +21,11 @@
 #define _IEEE1394_NODEMGR_H
 #include <linux/device.h>
+#include <asm/system.h>
 #include <asm/types.h>
 #include "ieee1394_core.h"
+#include "ieee1394_transactions.h"
 #include "ieee1394_types.h"
 struct csr1212_csr;
@@ -157,6 +159,22 @@ static inline int hpsb_node_entry_valid(
 void hpsb_node_fill_packet(struct node_entry *ne, struct hpsb_packet *packet);
 int hpsb_node_write(struct node_entry *ne, u64 addr,
 		    quadlet_t *buffer, size_t length);
+static inline int hpsb_node_read(struct node_entry *ne, u64 addr,
+				 quadlet_t *buffer, size_t length)
+	unsigned int g = ne->generation;
+	smp_rmb();
+	return hpsb_read(ne->host, ne->nodeid, g, addr, buffer, length);
+static inline int hpsb_node_lock(struct node_entry *ne, u64 addr, int extcode,
+				 quadlet_t *buffer, quadlet_t arg)
+	unsigned int g = ne->generation;
+	smp_rmb();
+	return hpsb_lock(ne->host, ne->nodeid, g, addr, extcode, buffer, arg);
 int nodemgr_for_each_host(void *data, int (*cb)(struct hpsb_host *, void *));
 int init_ieee1394_nodemgr(void);

Stefan Richter
-=====-==--- =--= ===-=

More information about the devel mailing list