[patch 00/10] firedtv: a few more updates

Stefan Richter stefanr at s5r6.in-berlin.de
Mon Sep 29 17:15:44 UTC 2008

Hi list,

here are some more cleanups to the firedtv driver.  As mentioned during
the last round of updates, this driver is currently hosted in a branch
at kernel.org's linux1394-2.6.git repo (actually three branches) with
the goal to make it merge-ready for 2.6.28(-rc1) --- I hope.  Quilt
series exist too.  More info about the git branches and quilt series can
be found at http://user.in-berlin.de/~s5r6/linux1394/firedtv/.  I will
upload the new patches to these repos later today.

This series of updates touches the ieee1394 interface of the driver and
cleans up some aspects of the driver initialization and device probing.
The three ieee1394 core patches in this series have already been posted
to the linux1394-devel mailinglist a while ago.

What I would still like to do before posting a proper announcement and
review patch on LKML is
  - many trivial stylistic cleanups,
  - don't use bitfields for on-the-wire data (there is a bug with big
    endian CPUs in the driver due to its bitfields),
  - rename variables, functions, files, and the driver subdirectory
    from firesat to firedtv.  (The module is already called firedtv.)

I will follow up with the following patches:

 01/10 ieee1394: use correct barrier types between accesses of nodeid and generation
 02/10 ieee1394: add hpsb_node_read() and hpsb_node_lock()
 03/10 ieee1394: inherit ud vendor_id from node vendor_id
 04/10 firedtv: use hpsb_node_read(), _write(), _lock()
 05/10 firedtv: add vendor_id and version to driver match table
 06/10 firedtv: remove unused dual subunit code from initialization
 07/10 firedtv: fix initialization of dvb_frontend.ops
 08/10 firedtv: remove unused struct members
 09/10 firedtv: fix string comparison and a few sparse warnings
 10/10 firedtv: register input device as child of a FireWire device

Combined diffstat:

 drivers/ieee1394/nodemgr.c               |   10
 drivers/ieee1394/nodemgr.h               |   18 +
 drivers/media/dvb/firesat/avc_api.c      |  187 ++++----------
 drivers/media/dvb/firesat/avc_api.h      |    7
 drivers/media/dvb/firesat/cmp.c          |    7
 drivers/media/dvb/firesat/firesat-ci.c   |   15 -
 drivers/media/dvb/firesat/firesat-ci.h   |    2
 drivers/media/dvb/firesat/firesat-rc.c   |   42 ++-
 drivers/media/dvb/firesat/firesat-rc.h   |    9
 drivers/media/dvb/firesat/firesat.h      |   68 ++---
 drivers/media/dvb/firesat/firesat_1394.c |  293 ++++++++---------------
 drivers/media/dvb/firesat/firesat_dvb.c  |  183 ++++++--------
 drivers/media/dvb/firesat/firesat_fe.c   |  183 ++++++--------
 drivers/media/dvb/firesat/firesat_iso.c  |    3
 14 files changed, 424 insertions(+), 603 deletions(-)

The patches have been compile-tested with linux 2.6.25, .26, .27-rc7 and
runtime tested with .27-rc7 and a FireDTV DVB-C box.
Stefan Richter
-=====-==--- =--= ===-=

More information about the devel mailing list