usb test & measurement driver cleanup

Greg KH gregkh at suse.de
Thu Jun 19 10:42:36 UTC 2008


On Thu, Jun 19, 2008 at 01:19:08PM +0300, Felipe Balbi wrote:
> -#ifdef USBTMC_DEBUG
> -	printk(KERN_NOTICE "USBTMC: usbtmc_open called\n");
> -#endif

Hm, you just removed most of these debug calls.  Why not use the proper
dev_dbg() call instead?  That way they can remain and get enabled if the
config option is enabled that turns on debugging for the usb drivers?

thanks,

greg k-h



More information about the devel mailing list