usb test & measurement driver cleanup

Greg KH gregkh at suse.de
Thu Jul 3 16:45:26 UTC 2008


On Thu, Jul 03, 2008 at 12:19:47PM +0300, Felipe Balbi wrote:
> On 7/3/08, Greg KH <greg at kroah.com> wrote:
> 
> > I also did a bunch more work on the driver right now, so you might want
> >  to refresh your version if you are going to do any more work on it.
> >
> >  That ioctl interface really needs to go away, I should go re-read the
> >  spec to see if the attribute/value mess is needed.
> >
> >  We should also use the usb major number instead of creating our own,
> >  that will remove a bunch of code.
> 
> Cool, I'm planning to do more work on that.
> I'll refresh here and also re-read the specs. It's quite a mess that driver.

Yes it is :)

After reading the spec, I think the majority of those ioctls can just be
moved to sysfs files.

> Probaly I'll first start using usb major number and after that check the ioctls.

Great.  I'll leave it alone for a week or so (vacation and work travel),
so feel free to hack away at it.

thanks,

greg k-h



More information about the devel mailing list