[PATCH] firesat avc resend

Stefan Richter stefanr at s5r6.in-berlin.de
Sun Aug 24 21:25:19 UTC 2008


I wrote:
> I too worked on some updates yesterday.  I will rebase 
> them on Henrik's patch and post them Monday or Tuesday:

or right now.  Next up, coming as replies to this post:

 1/7 - firesat: add missing copyright notes
 2/7 - firesat: rename to firedtv
 3/7 - firedtv: nicer registration message and some initialization fixes
 4/7 - firedtv: some header cleanups
 5/7 - firedtv: replace semaphore by mutex
 6/7 - firedtv: move some code back to ieee1394 core
 7/7 - firedtv: drop pre-2.6.26 compatibility

Patch 3/7 is not 100% consequent; initialization errors which get passe
up are not yet handled as necessary by the caller.

Patch 5/7 cops out in a tasklet which does a down_try but cannot do
mutex_trylock.  At the moment, the tasklet is dead code anyway because
the remote control handling is disabled.  Hence I put that portion
simply into #if 0/#endif.  However, it seems the tasklet can and should
be converted into a workqueue job which then can easily work with the
mutex, and also can do other things better than a tasklet.

Patch 7/7 is being posted FYI.  I will requeue it to the end of the
patch series whenever new firedtv patches arrive, so that it will become
the last or one of the last commits before the snapshot that I'll
propose for mainline.  That way people can easier work on firedtv based
on e.g. 2.6.25.y if they want.

Comments and corrections to the 7 patches are very welcome.

 drivers/ieee1394/dma.h                   |    1 
 drivers/ieee1394/ieee1394_core.c         |    1 
 drivers/ieee1394/ieee1394_transactions.c |   29 ++++
 drivers/ieee1394/ieee1394_transactions.h |    2 
 drivers/ieee1394/iso.h                   |    1 
 drivers/media/dvb/Makefile               |    2 
 drivers/media/dvb/firesat/Kconfig        |   13 +-
 drivers/media/dvb/firesat/Makefile       |    4 
 drivers/media/dvb/firesat/avc_api.c      |   37 +++--
 drivers/media/dvb/firesat/avc_api.h      |  108 ++++++++--------
 drivers/media/dvb/firesat/cmp.c          |   99 ++++-----------
 drivers/media/dvb/firesat/cmp.h          |   14 +-
 drivers/media/dvb/firesat/firesat-ci.c   |   16 +-
 drivers/media/dvb/firesat/firesat-ci.h   |    8 -
 drivers/media/dvb/firesat/firesat-rc.c   |   14 +-
 drivers/media/dvb/firesat/firesat-rc.h   |   13 +-
 drivers/media/dvb/firesat/firesat.h      |   80 ++++++------
 drivers/media/dvb/firesat/firesat_1394.c |  139 ++++++++-------------
 drivers/media/dvb/firesat/firesat_dvb.c  |  147 +++++++----------------
 drivers/media/dvb/firesat/firesat_fe.c   |   41 ++----
 drivers/media/dvb/firesat/firesat_iso.c  |   12 +
 21 files changed, 350 insertions(+), 431 deletions(-)
-- 
Stefan Richter
-=====-==--- =--- ==---
http://arcgraph.de/sr/




More information about the devel mailing list