[PATCH] staging: olpc_dcon.c: checkpatch.pl and style fixups
gregkh at linuxfoundation.org
Wed Apr 18 16:30:04 PDT 2012
On Sun, Apr 15, 2012 at 12:53:04AM +0200, Jesper Juhl wrote:
> This patch removes the few checkpatch.pl issues that are currently
> reported for this file.
> It makes these changes:
> 1. Quoted strings that were broken over multiple lines are put on a
> single line for easier grep'ability.
Woah, no, a patch should only do one single thing.
If you have to list what it does, you are not doing it correctly.
And, as this patch shows, people liked part of it, but not others, so
you had to redo it. If you had split this up into individual patches, I
could have just accepted those and not the others.
So please, always break your patches up into the proper pieces.
More information about the devel