[PATCH] Missing attribute list NULL terminator
dan.carpenter at oracle.com
Wed Apr 11 14:40:00 PDT 2012
This is the wrong list. Send the patch to the output from
./scripts/get_maintainer.pl. You can normally drop linux-kernel
from the CC list unless it's something very important. But you
always need to CC at least one list, so CC linux-kernel if there is
no other list for the subsystem.
On Wed, Apr 11, 2012 at 03:27:35PM -0500, Matt Renzelmann wrote:
> I've never submitted a patch before or posted to a kernel mailing list, so I
> hope I've done everything necessary.
Save your email as raw text including the headers and everything.
cat raw_email.txt | git am
The changelog is a bit messed up. The trick is to put extra
commentary which doesn't belong in the change log under a "---"
under the Signed-off-by line.
Signed-off-by: Matt Renzelmann <mjr at cs.wisc.edu>
Comments go here.
> The following patch is against Linus's tree.
Always make patches against the linux-next tree. In this case, it's
the same thing so no problem.
> Please let me know if I've screwed anything up, or if this is not a
> genuine bug.
In the changelog put some justification for why we should apply the
patch. In this case it would be, "Our static analysis tool noticed
that all the other attribute arrays end in a NULL except this one."
or something like that. It helps us know what to do with the patch.
It is a real bug. The for loop in create_files() from
fs/sysfs/group.c uses the NULL to know when to end. The reason that
no one has noticed this before is because "lp5523_group" has a NULL
.name pointer. Otherwise, we would would get a bogus dereference on
So can you clean up the changelog, add in the information I've told
you and resend it to the people from get_maintainer.pl.
More information about the devel