[PATCH 00/20] staging: brcm80211: 7th reaction for mainline patch #2
m at bues.ch
Thu Sep 22 03:29:47 PDT 2011
On Thu, 22 Sep 2011 11:44:35 +0200
Johannes Berg <johannes at sipsolutions.net> wrote:
> I agree that would be nice. However, I don't think that it should be
> required for brcmsmac to get into mainline, nor do I think that there
> should be a big rearchitecture for this. In fact, brcmsmac has a PHY
> abstraction layer that looks perfectly usable to me. b43 has one too,
> but it's nowhere near as fleshed out for all corner cases afaict.
> Really the more important issue is support though. Rafal by himself
> cannot possibly provide the level of support we're hoping to see from
> Broadcom who I expect will eventually ship this driver to their
> customers and support it, just like they do now with the driver it is
> derived from.
> Overall, the way I see it this really is a no-brainer. I really don't
> see why we're even discussing this so much.
> brcmsmac should be accepted into mainline as soon as possible (and I
> think all the recent patchsets go a long way). After that, the Broadcom
> team can easily port it to bcma, I expect that would happen within a few
> weeks. Adding features to it should be fairly simple too, and go much
> faster than adding any features to b43. (*)
I fully agree with all of that.
It is time to merge the stuff into mainline. There really is no other option.
> b43 is really my child too. I spent a very long time on the reverse
> engineering. But let's let it "die" peacefully.
We all put a lot of effort into b43, but that does not imply that we have
to beat the dead horse.
b43 has to become a second b43legacy. Which means it must go into maintenance-only mode.
Features should probably be removed, too. But that has to be done after
mainlining of brcmsmac.
Completely dropping either of b43 or brcmsmac is not an option. So, Rafal, you can still
continue to work on b43. There are _lots_ of bugs and issues to fix/improve.
If you need/want some older b43 devices, I can certainly donate some of mine to you. (I have
at least piece one of any flavor of supported 802.11g devices in stock).
More information about the devel