[PATCH 00/20] staging: brcm80211: 7th reaction for mainline patch #2
johannes at sipsolutions.net
Thu Sep 22 02:44:35 PDT 2011
On Thu, 2011-09-22 at 00:35 +0200, Michael Büsch wrote:
> And for that single reason I do not see either b43 or brcmsmac being dropped
> in favor of the other one any time soon.
> You guys obviously don't want to support legacy hardware. So there is absolutely
> no way to drop b43 in favor of brcmsmac. That is _impossible_.
> And I do agree that it would be completely insane for you guys to support the legacy
> b43 802.11g code.
> The other way around, dropping brcmsmac in favor of b43 would be insanely stupid, too.
> It would basically be dropping broadcom-linux-wlan support. Nobody wants that.
All good points. The most rational I've seen in all of this discussion
> I do, however, think that a separate broadcom-supported PHY module should be created,
> that is used by both brcmsmac and b43.
I agree that would be nice. However, I don't think that it should be
required for brcmsmac to get into mainline, nor do I think that there
should be a big rearchitecture for this. In fact, brcmsmac has a PHY
abstraction layer that looks perfectly usable to me. b43 has one too,
but it's nowhere near as fleshed out for all corner cases afaict.
Really the more important issue is support though. Rafal by himself
cannot possibly provide the level of support we're hoping to see from
Broadcom who I expect will eventually ship this driver to their
customers and support it, just like they do now with the driver it is
Overall, the way I see it this really is a no-brainer. I really don't
see why we're even discussing this so much.
brcmsmac should be accepted into mainline as soon as possible (and I
think all the recent patchsets go a long way). After that, the Broadcom
team can easily port it to bcma, I expect that would happen within a few
weeks. Adding features to it should be fairly simple too, and go much
faster than adding any features to b43. (*)
b43 is really my child too. I spent a very long time on the reverse
engineering. But let's let it "die" peacefully. It has no reason to be
competing with a Broadcom-supported driver that supports the same chips.
(*) Rafal: Also, get a grip. Your much touted "monitor mode" is probably
a 50-100 line patch to brcmsmac. You're making yourself look extremely
childish by talking about it all the time as if it was the best thing
since sliced bread.
More information about the devel