[PATCH v5] staging: Add ST-Ericsson CG2900 driver
par-gunnar.p.hjalmdahl at stericsson.com
Mon May 9 05:07:02 PDT 2011
> -----Original Message-----
> From: Greg KH [mailto:greg at kroah.com]
> Sent: den 3 maj 2011 19:50
> What changed in this version? It still doesn't apply properly to the
> linux-next tree, which shows me that I don't think anything really
> changed here.
What I changed from v4 was in particular to adapt to changes to mfd.
The mfd device data name had been changed from platform_data (plus length)
to mfd_data. This was modified cg2900_chip.c and stlc2690.c.
In connection to this I also modified so we used the function mfd_get_data
to retrieve the platform data.
There had also been one parameter removed in the call to tty->ops->tiocmget
so I had to modify the call in hci_ldisc as well.
> Can you rediff it so it properly applies (i.e. why are you adding your
> driver to the middle of drivers/staging/Makefile and not at the end
> which is where it properly belongs?) and resend it?
I will do another try, but I honestly do not know why it doesn't apply.
The reason for the placement in the makefile I do not remember at the
moment, probably just a simple mistake from my part. I agree that I
should have placed it last in the file.
More information about the devel